Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR: Add refresh rate signal support #90374

Merged

Conversation

BastiaanOlij
Copy link
Contributor

Just a little QOL PR. This implements the refresh rate signal that is part of the already supported refresh rate extension. It allows the user to get a signal if the refresh rate on the headset changes.

It seems this is only emitted on headsets that allow us to set the refresh rate. But this at least completely implements this extension.

@BastiaanOlij BastiaanOlij added this to the 4.3 milestone Apr 8, 2024
@BastiaanOlij BastiaanOlij self-assigned this Apr 8, 2024
@BastiaanOlij BastiaanOlij requested review from dsnopek, Malcolmnixon and a team April 8, 2024 02:54
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akien-mga akien-mga merged commit 0fd440e into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the openxr_refresh_rate_signal branch April 10, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants