Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add POST_NOTIFICATIONS permission to the list of permissions available in the Export dialog #90377

Conversation

melquiadess
Copy link
Contributor

@melquiadess melquiadess commented Apr 8, 2024

Fixes #75673

As in subject

Screenshot 2024-04-08 094705

The permission is in the AndroidManifest of the resulting app:

Screenshot 2024-04-07 215701

HOW TO TEST

  • build the engine/Android export templates
  • select the new notification permission with its checkbox
  • export the apk
  • inspect AndroidManifest.xml of the exported apk (you can drag/drop to Android Studio and check it there)

@melquiadess melquiadess requested a review from a team as a code owner April 8, 2024 08:31
@melquiadess melquiadess force-pushed the add-post-notification-permission-to-a-list-of-available-permissions branch from 6f064c1 to 739190c Compare April 8, 2024 08:45
@akien-mga akien-mga changed the title Android: Add POST_NOTIFICATIONS permission to the list of permissions available in the Export dialog Android: Add POST_NOTIFICATIONS permission to the list of permissions available in the Export dialog Apr 8, 2024
@akien-mga akien-mga added this to the 4.x milestone Apr 8, 2024
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 8, 2024
@m4gr3d m4gr3d modified the milestones: 4.x, 4.3 Apr 8, 2024
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

@akien-mga akien-mga merged commit 0d0d23c into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@melquiadess melquiadess deleted the add-post-notification-permission-to-a-list-of-available-permissions branch April 8, 2024 19:39
@@ -380,6 +380,9 @@
<member name="permissions/persistent_activity" type="bool" setter="" getter="" deprecated="Deprecated in API level 15.">
Allow an application to make its activities persistent.
</member>
<member name="permissions/post_notifications" type="bool" setter="" getter="" deprecated="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the deprecated="" which was likely copied from one of the surrounding errors. This will mark this entry as deprecated in the docs, when that's not intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, my bad, thanks for noticing. I'll remove it in another PR - I believe a few other permission properties could use an update to their description...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #90546

@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga
Copy link
Member

Cherry-picked for 3.6.
Cherry-picked for 3.5.4.

@akien-mga akien-mga removed cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing POST_NOTIFICATIONS permission
3 participants