Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add hint for required ios camera plugin in CameraServer documentation #90389

Merged

Conversation

Krigu
Copy link
Contributor

@Krigu Krigu commented Apr 8, 2024

Added hint for using the CameraServer on iOS, since reading the previous docs suggested that the CameraFeed will work out of the box in iOS (which it does not).

@Krigu Krigu requested a review from a team as a code owner April 8, 2024 14:28
@AThousandShips AThousandShips changed the title Doc: Added hint for required ios camera plugin in CameraServer documentation Doc: Add hint for required ios camera plugin in CameraServer documentation Apr 8, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Apr 8, 2024
@mhilbrunner
Copy link
Member

mhilbrunner commented Apr 9, 2024

Looks good to me, the commits need to be squashed though so there is only one (see here). Thanks for contributing!

@Krigu Krigu force-pushed the update_documentation_for_camera_server_ios branch from bef0477 to 1ad39e1 Compare April 9, 2024 20:02
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 9, 2024
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 9, 2024
@akien-mga akien-mga merged commit d68e04d into godotengine:master Apr 10, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants