Move engine build profile editor to Tools submenu #90441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename it to Engine Compilation Configuration Editor. This makes
it clearer that it requires compiling the engine to work ("build"
can be understood as exporting a project or building C# solutions
by some).
- Add it to the editor command palette and allow defining a keyboard
shortcut for it, for consistency with other tools.
fire
approved these changes
Apr 9, 2024
akien-mga
approved these changes
Apr 10, 2024
|
Note that this introduces an inconsistency with the name of the actual compilation option: And changing it would be compat breaking so not worth it for a minor language nitpick. Might be fine as is anyway. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview