Fix theme_override tooltip caching
#90446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theme_override properties have some special handling in EditorInspector. When caching documentation info for properties, the theme_item_name value (used only for theme_overrides) was not being cached, so it would only be included on first use. This meant that theme_override property tooltips would show up in the editor the first time a node was selected, but not again after selecting something else/reselecting. Added theme_item_name to caching to fix this. Fixes godotengine#90395
KoBeWi
approved these changes
Apr 16, 2024
akien-mga
changed the title
theme_override tooltip caching
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theme_override properties have some special handling in
EditorInspector. When caching documentation info for properties, the theme_item_name value (used only for theme_overrides) was not being cached, so it would only be included on first use. This meant that theme_override property tooltips would show up in the editor the first time a node was selected, but not again after selecting something else/reselecting. Added theme_item_name to caching to fix this.Fixes #90395