SCons: Fix SCU build regression on Windows #90450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR godotengine#89452 made assumptions on comparing paths as strings which doesn't work when composing them as POSIX paths (`/`) but processing them on NT (`\`, `\\`).
akien-mga
force-pushed
the
scons-fix-scu-windows
branch
from
c5f0d8c
to
9ad140f
Compare
lawnjelly
approved these changes
Apr 9, 2024
|
I tested and confirmed that this change doesn't break SCU build for me on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#89452 made assumptions on comparing paths as strings which doesn't work when composing them as POSIX paths (
/) but processing them on NT (\,\\).This is more of a PoC of what needs to be done, we should get rid of any string comparisons and standardize everything around
pathlib.Path, oros.path.join(), but not a mix of concatenatingbase + "/scu/" + tailand then trying to compare that to Windows paths, because we end up with stuff like this:C:\\Users\\Remi\\Dev\\Godot\\godot\\servers\\audio\\effects\\scu/scu_servers_audio_effects.gen.cppand failing comparisons.