Fix caret last fit when moving to line end #90455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also fix #90462? |
|
akien-mga
approved these changes
Apr 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT_MAX was being used and it overflowed when subtracting 0.0 from it, which caused it to become negative, so the caret went to the start of the line.
It's not needed to be set here, since set_caret_column handles it.
It should be set to the end of the line anyway and not a high value, judging by behavior in other text editors.
For the other point in the issue, I couldn't find any problems with the caret moving down incorrectly. The caret will only go not straight down if the last fit was set to a column higher than the line end, which is intended.