Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Prevent crash in interactive playback #90481

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

AThousandShips
Copy link
Member

This is in two parts, first part is fixing the crash itself, second part is ensuring the class can't be created on its own, can remove if desired but I'd say it makes sense as these make no sense created independently as they are unconfigured

@AThousandShips AThousandShips force-pushed the interactive_playback branch from 447e665 to 8a52837 Compare May 13, 2024 11:55
@AThousandShips AThousandShips modified the milestones: 4.3, 4.4 Jul 7, 2024
@AThousandShips
Copy link
Member Author

Realized that the classes are 4.3 so returning this to 4.3 and removing compat breakage as it doesn't for 4.3

@AThousandShips AThousandShips modified the milestones: 4.4, 4.3 Jul 17, 2024
@AThousandShips AThousandShips requested a review from a team July 17, 2024 14:21
@akien-mga akien-mga merged commit 83dd741 into godotengine:master Jul 18, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the interactive_playback branch July 18, 2024 08:51
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing AudioStreamPlaybackInteractive.switch_to_clip_by_name function crashes Godot
3 participants