[Audio] Prevent crash in interactive playback #90481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Apr 10, 2024
AThousandShips
force-pushed
the
interactive_playback
branch
from
447e665
to
8a52837
Compare
AThousandShips
force-pushed
the
interactive_playback
branch
from
8a52837
to
d6b68d2
Compare
AThousandShips
force-pushed
the
interactive_playback
branch
from
d6b68d2
to
4faa943
Compare
|
Realized that the classes are 4.3 so returning this to 4.3 and removing compat breakage as it doesn't for 4.3 |
AThousandShips
force-pushed
the
interactive_playback
branch
from
4faa943
to
2878dd4
Compare
AThousandShips
force-pushed
the
interactive_playback
branch
from
2878dd4
to
be652f1
Compare
akien-mga
approved these changes
Jul 17, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in two parts, first part is fixing the crash itself, second part is ensuring the class can't be created on its own, can remove if desired but I'd say it makes sense as these make no sense created independently as they are unconfigured
AudioStreamPlaybackInteractive.switch_to_clip_by_namefunction crashes Godot #90474