Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection dialog raise error when it was previously opened in another scene #90514

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix connection dialog raise error when it was previously opened in another scene #90514

merged 1 commit into from
Apr 11, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #90486

The problem lies in the order of these lines, in ConnectDialog::init it will set the marked node and in popup_dialog it will use the marked node, if the order is inversed, then the marked node is from previous scene and hence the error.

@akien-mga akien-mga added this to the 4.3 milestone Apr 11, 2024
@akien-mga akien-mga requested a review from KoBeWi April 11, 2024 06:38
akien-mga
akien-mga approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rationale makes sense to me

I'm curious to know what PR caused the regression though to see why this was written/changed this way.

@jsjtxietian
Copy link
Contributor Author

jsjtxietian commented Apr 11, 2024 •
edited
Loading

what PR caused the regression

This one #85386. The popup_dialog will cause NOTIFICATION_VISIBILITY_CHANGED on the scene tree editor and let it use the old marked node.

@akien-mga akien-mga merged commit b2f425f into godotengine:master Apr 11, 2024
16 checks passed
@jsjtxietian jsjtxietian deleted the connection-dialog branch April 11, 2024 09:11
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@KoBeWi KoBeWi Awaiting requested review from KoBeWi

Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Opening connection dialog results in an error if it was previously opened in another scene
2 participants
@jsjtxietian @akien-mga