Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static allocation bones copy for SkeletonModifier #90517

Merged
merged 1 commit into from
May 4, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Apr 11, 2024

Co-authored-by: @SlugFiller

The original bone pose is copied/restored before and after the Skeleton modification process. This PR make it use static allocation and memcpy.

@TokageItLab TokageItLab added this to the 4.3 milestone Apr 11, 2024
@TokageItLab TokageItLab requested a review from a team as a code owner April 11, 2024 06:35
@TokageItLab TokageItLab requested a review from a team April 11, 2024 06:37
@TokageItLab TokageItLab force-pushed the cache-bones-mod branch 5 times, most recently from fa32ad5 to 128976d Compare April 11, 2024 07:58
@TokageItLab
Copy link
Member Author

TokageItLab commented Apr 11, 2024

Bone does not seem to be trivially-copyable (can't mamcpy..), so I changed the approach to static allocating the LocalVector of the structure for backup.

scene/3d/skeleton_3d.h Outdated Show resolved Hide resolved
Co-authored-by: SlugFiller <5435495+SlugFiller@users.noreply.github.com>
@akien-mga akien-mga merged commit a5d4ddc into godotengine:master May 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the cache-bones-mod branch June 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants