Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbedTLS: Add patch to fix build errors with some MSVC versions #90535

Merged
merged 1 commit into from
Apr 12, 2024
Merged

mbedTLS: Add patch to fix build errors with some MSVC versions #90535

merged 1 commit into from
Apr 12, 2024

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Apr 11, 2024

Fixes #90526

@Faless Faless added this to the 4.3 milestone Apr 11, 2024
@Faless Faless requested a review from a team as a code owner April 11, 2024 13:52
@Faless Faless mentioned this pull request Apr 11, 2024
Closed
@Faless Faless marked this pull request as draft April 11, 2024 13:57
@Faless Faless marked this pull request as ready for review April 11, 2024 14:07
@Faless Faless marked this pull request as draft April 11, 2024 14:09
@Faless Faless marked this pull request as ready for review April 11, 2024 14:12
Bromeon
Bromeon approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also encountered this problem, both locally and in CI.

Can confirm this PR fixes it, thanks a lot!

@akien-mga akien-mga merged commit 60db4bd into godotengine:master Apr 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Faless Faless deleted the fix/mbedtls-msvc-is-fun branch April 12, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:buildsystem topic:core topic:thirdparty
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Compilation errors with Windows/MSVC from VS 2019 after mbedTLS update
3 participants
@Faless @akien-mga @Bromeon