Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when scene/resource is saved with newer format #90571

Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 12, 2024

Currently opening a scene saved in a new format results in very unhelpful message:

This PR improves it:
image

@KoBeWi KoBeWi added this to the 4.3 milestone Apr 12, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bit better indeed.

@rburing
Copy link
Member

rburing commented Apr 12, 2024

I would maybe write "in a format that is newer than the formats supported by this version of Godot, so it can't be opened".

(Could also insert the Godot version.)

@KoBeWi
Copy link
Member Author

KoBeWi commented Apr 14, 2024

That's too long, the dialog does not support autowrapping.

@akien-mga
Copy link
Member

That's too long, the dialog does not support autowrapping.

Sounds like something we should fix, the scene load errors are so critical that we really ought to give proper details to users.

@KoBeWi
Copy link
Member Author

KoBeWi commented Apr 15, 2024

With autowrap:
image

@KoBeWi KoBeWi force-pushed the you're_too_old,_upgrade_to_newer_format branch from 9f797ef to 445302a Compare April 15, 2024 10:08
@akien-mga akien-mga merged commit e1dd1f4 into godotengine:master Apr 15, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the you're_too_old,_upgrade_to_newer_format branch April 15, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants