SCons: Fix silence_msvc regression
#90626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90617
While I couldn't directly recreate the situation in the issue, knowing that the problem was a
UnicodeDecodeErrormade solving it mercifully straightforward. Instead of the direct approach via my text-based method, this adopts a process closer to what's used in SCons natively: parsing as bytes initially & decoding after the fact with the error handler "replace"1. This would've been quite bulky if it remained a one-liner, so the logic has been spread out; consequently, performance should be improved by gathering a file's content exactly once & performing a decode only if it's guaranteed to be an error.Footnotes
https://docs.python.org/3/library/codecs.html#error-handlers ↩