mbedTLS: Fix build without the module on MinGW #90691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Apr 15, 2024
akien-mga
approved these changes
Apr 15, 2024
The `include/mbedtls/check_config.h` header file has a generic check which requires `MBEDTLS_PLATFORM_C` to be defined on Windows when building with MinGW and ancient MSVC versions. The few mbedTLS files we include in builds without the module don't really require anything from the mbedTLS platform file beside the `mbedtls_platform_zeroize` function which we already override with a custom one by defining `MBEDTLS_PLATFORM_ZEROIZE_ALT`. So we simply add the same check and force the define in such case.
Faless
force-pushed
the
fix/mbedtls_core_config_mingw
branch
from
c88eecb to
060097b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
include/mbedtls/check_config.hheader file has a generic check which requiresMBEDTLS_PLATFORM_Cto be defined on Windows when building with MinGW and ancient MSVC versions.The few mbedTLS files we include in builds without the module don't really require anything from the mbedTLS platform file beside the
mbedtls_platform_zeroizefunction which we already override with a custom one by definingMBEDTLS_PLATFORM_ZEROIZE_ALT.So we simply add the same check and force the define in such case.
Fixes #90652