-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow closing scene tab preview using Escape #90720
Conversation
Instead of a new keybind, you can check for |
I modified it to check for |
I made some changes based on your comments. Sorry if my solution is kind of naive, this is my first time working with open source. Also, let me know if there is anything else that should be done differently. Thank you for the feedback. |
This comment was marked as outdated.
This comment was marked as outdated.
It should be squashed down to one commit now. Is there anything else I should do or need to change? (also sorry, I just saw you said after it's approved, I can squash it again after if I need to make another commit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more style comments, but the implementation looks alright now.
Okay, sounds good, thanks for taking the time to look at this and giving me feedback. I'm super new to this codebase so it was very helpful. |
This comment was marked as outdated.
This comment was marked as outdated.
You need to squash again. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Fixes #90706
This PR is a potential implementation for closing the tooltip window which appears after hovering over a tab in the editor.
To test this code, open multiple scenes in the editor, hover over an inactive scene and once the panel pops up, press escape to close it.