Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NavigationMeshSourceGeometryData(2D/3D) to the 2D/3D subfolders #90729

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

aaronfranke
Copy link
Member

Follow-up to other organization PRs like PR #83133. This PR does the following:

  • Move NavigationMeshSourceGeometryData2D into scene/resources/2d
  • Move NavigationMeshSourceGeometryData3D into scene/resources/3d
  • Move NavigationPolygon2D into scene/resources/2d
    • Note: Can't move the 3D equivalent NavigationMesh3D because it's needed for 2D navigation.
  • In NavigationServer3D, disable parse_source_geometry_data, bake_from_source_geometry_data, bake_from_source_geometry_data_async, and is_baking_navigation_mesh when compiling without 3D.
    • NavigationServer3D is still used when compiling without 3D, but these methods are 3D-only. NavigationServer2D has separate methods with the same names that operate on the 2D versions of these classes.

@AThousandShips AThousandShips added this to the 4.x milestone Apr 16, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 16, 2024
@akien-mga akien-mga merged commit 09825bc into godotengine:master Apr 16, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the move-nav-msgd branch April 16, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants