-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TreeItem button handling #90839
Fix TreeItem button handling #90839
Conversation
Would it make sense to do the revert part only for 4.1 and 4.2, while the rest of the more involved fix gets assessed for 4.3? |
Ah yeah, the bug it worked around only exists if you make a tree too narrow, adjusting window size solves the problem. But the regression it caused has no workaround, many tree buttons in the editor lost their tooltips. |
Could you make a revert PR for 4.2 with |
Or well actually, maybe do a revert PR for master to merge first and cherry-pick (reopening the original issue), and then rebase this one on top. |
OK, done. #90842. I'll rebase this one after it's merged. |
- Fix incorrect tooltip and `get_button_id_at_position()` when column title is visible and when RTL layout is used - Take `button_margin`, `h_separation`, and `item_margin` into account
Thanks! |
Fixes #79629
This PR mainly fixes
get_tooltip()
andget_button_id_at_position()
:button_margin
,h_separation
, anditem_margin
into account.TestProject.zip