GDExtension: Fix missing library path breaking hot reloading #90961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Good catch, thanks!
It looks like I missed this in my review of PR #87117: we used to pass &library_path into OS::open_dynamic_library() which would lead to it getting set, but now its being stored in an intermediate variable, so we need to explicitly set it.
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDExtension::open_librarywas forgetting to setlibrary_pathfor the extension, which was causinghas_library_changed()to always return true (reading the modification time of the root directory instead of the library path) and reloading libraries every time the editor focus changed even if the file was not modified, causing huge slowdowns.