Document AudioEffectSpectrumAnalyzerInstance, clarify relationship with AudioEffectSpectrumAnalyzer #91034
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.1
|
Thanks for contributing! The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that. While doing that, rebasing on a more recent master commit may also help fix the CI errors. |
bpseudopod
force-pushed
the
aesa-documentation
branch
from
c014164
to
410d393
Compare
|
Okay, I'm not quite sure if I did it right but I've pulled and squashed to the best of my abilities. |
…th AudioEffectSpectrumAnalyzer Fully document AudioEffectSpectrumAnalyzerInstance, including the weird return value of its sole method, and add a link to it in AudioEffectSpectrumAnalyzer to make it easier to figure out how to use.
bpseudopod
force-pushed
the
aesa-documentation
branch
from
410d393
to
b6c0d07
Compare
|
fixed it by the way |
akien-mga
approved these changes
Jun 28, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully document AudioEffectSpectrumAnalyzerInstance, including the weird return value of its sole method, and add a link to it in AudioEffectSpectrumAnalyzer to make it easier to figure out how to use.
I looked through the source code so no-one else has to.