Fix issue with copy shader not working in multiview #91059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Malcolmnixon if you can test this and verify it indeed fixes your issue? I didn't reproduce the issue but in theory this should fix it. |
|
Do you know which PR introduced the regression? We'd need to check it's not being cherry-picked, or that this fix would be cherry-picked alongside it. |
|
I think it might be PR #90821 that introduced the issue. |
akien-mga
added
the
cherrypick:4.2
|
@clayjohn I'll let you evaluate whether we'd like to cherry-pick both or neither. |
clayjohn
approved these changes
Apr 23, 2024
|
Let's cherrypick both! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix this error reported by @Malcolmnixon :
In multiview
uv_interpis a vec3 variable, we need to swizzle it to allow this multiplication.