Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify MultiplayerSpawner scene path error checking. #91084

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Modify MultiplayerSpawner scene path error checking. #91084

merged 1 commit into from
Jun 21, 2024

Conversation

OwenAEdwards
Copy link
Contributor

@OwenAEdwards OwenAEdwards commented Apr 23, 2024 •
edited by akien-mga
Loading

@OwenAEdwards OwenAEdwards mentioned this pull request Apr 23, 2024
Closed
@akien-mga akien-mga requested a review from a team April 24, 2024 06:27
@akien-mga akien-mga added this to the 4.3 milestone Apr 24, 2024
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 24, 2024
@AThousandShips AThousandShips changed the title Modified MultPlayer spawnable scene path error checking. Modify MultiplayerSpawner scene path error checking. Apr 24, 2024
Faless
Faless approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry I missed this before.

Looking great 🏆 ! Thanks for spotting this!

@akien-mga akien-mga merged commit e5c0f60 into godotengine:master Jun 21, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Summersay415 Summersay415 mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:multiplayer
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

MultiplayerSpawner doesn't work with UIDs
3 participants
@OwenAEdwards @akien-mga @Faless