Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink API support for Windows, expose symlink methods. #91100

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 24, 2024

Note: create_link require evelated privilegies or Developer Mode enabled.

@bruvzg bruvzg added this to the 4.x milestone Apr 24, 2024
@bruvzg bruvzg marked this pull request as ready for review April 28, 2024 12:29
@bruvzg bruvzg requested review from a team as code owners April 28, 2024 12:29
doc/classes/DirAccess.xml Outdated Show resolved Hide resolved
doc/classes/DirAccess.xml Outdated Show resolved Hide resolved
doc/classes/DirAccess.xml Outdated Show resolved Hide resolved
@Calinou
Copy link
Member

Calinou commented Apr 28, 2024

Does this address godotengine/godot-proposals#1329?

Adding create_link is possible, but in most cases it required admin privileges, so it won't be useful for most apps.

I thought this wasn't required anymore since Windows 10 when using actual symlinks (as opposed to junctions).

@bruvzg

This comment was marked as outdated.

@bruvzg
Copy link
Member Author

bruvzg commented Apr 28, 2024

I thought this wasn't required anymore since Windows 10 when using actual symlinks (as opposed to junctions).

No, seems like on Windows 10 and 11 it works without elevation only if Developer mode is enabled. But will add it anyway.

@bruvzg bruvzg changed the title Add symlink read support for Windows, expose symlink methods. Add symlink API support for Windows, expose symlink methods. Apr 28, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 29, 2024
@akien-mga akien-mga merged commit 3207014 into godotengine:master Apr 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants