Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show in filesystem option for file favorites #91158

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Arnklit
Copy link
Contributor

@Arnklit Arnklit commented Apr 25, 2024

This adds "Show in FileSystem" option for favorited files.

godot.windows.editor.x86_64_pya76Mk6bS.mp4

Shoutout @mihe for helping me out with this.

@Arnklit Arnklit requested a review from a team as a code owner April 25, 2024 13:50
editor/filesystem_dock.h Outdated Show resolved Hide resolved
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
@Arnklit Arnklit force-pushed the show-in-filesystem-favorites branch from a7c3019 to c94411a Compare April 25, 2024 15:17
@Arnklit
Copy link
Contributor Author

Arnklit commented Apr 25, 2024

Sorry created another formatting issue. I'll get them sorted and install those pre-commit hooks.

@Arnklit Arnklit force-pushed the show-in-filesystem-favorites branch from c94411a to ca2005f Compare April 26, 2024 08:03
Copy link
Contributor

@mihe mihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (whatever that's worth) from a code perspective.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 26, 2024
@akien-mga akien-mga merged commit ce539e5 into godotengine:master Apr 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Hyrilorius
Copy link

Nice ! Might be worth adding a custom shortcut setting for this ?

@Arnklit Arnklit deleted the show-in-filesystem-favorites branch October 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants