Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow compressed texture array and cubemap types in shader globals editor #91164

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Allow compressed texture array and cubemap types in shader globals editor #91164

merged 1 commit into from
Apr 26, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Apr 25, 2024

@Calinou Calinou added bug topic:editor topic:shaders cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 25, 2024
@Calinou Calinou added this to the 4.3 milestone Apr 25, 2024
@Calinou Calinou requested a review from a team as a code owner April 25, 2024 15:47
@akien-mga akien-mga merged commit 0510191 into godotengine:master Apr 26, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the shader-globals-editor-allow-compressed-texture-array-types branch April 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:editor topic:shaders
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Cannot add sampler2DArray as shader global due to strict class selection
3 participants
@Calinou @akien-mga @clayjohn