Don't use vscroll when fit to content height in TextEdit #91190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:4.2
akien-mga
approved these changes
Apr 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The horizontal scrollbar part was fixed in #83286
This makes sure that the vertical scroll bar won't be shown when fit to content height.
This fixes the crash mentioned in the issue. #80546 had a slightly different cause for the crash, which was fixed. This crash only happens at certain sizes depending on the text and is rarer.
This fixes it since in
_update_wrap_at_column, the v_scroll size is used, which is then removed next time it is updated, causing an infinite loop.