Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Variant documentation comment about class_name #91313

Merged
merged 1 commit into from
May 1, 2024

Conversation

fkeyzuwu
Copy link
Contributor

@fkeyzuwu fkeyzuwu commented Apr 29, 2024

Comment was outdated - you can now get a script's class_name easily by calling get_global_name() on the script of a given object.

@fkeyzuwu fkeyzuwu requested a review from a team as a code owner April 29, 2024 14:19
@AThousandShips AThousandShips added this to the 4.x milestone Apr 29, 2024
doc/classes/Variant.xml Outdated Show resolved Hide resolved
@mhilbrunner
Copy link
Member

Thanks for contributing :) The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that.

@fkeyzuwu
Copy link
Contributor Author

Thanks for contributing :) The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that.

done!

@AThousandShips
Copy link
Member

Please change the name of the commit to be more descriptive, explaining what the change is

@AThousandShips AThousandShips changed the title Update Variant.xml Outdated Comment Update Variant documentation comment about class_name Apr 30, 2024
@fkeyzuwu
Copy link
Contributor Author

Please change the name of the commit to be more descriptive, explaining what the change is

updated

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 30, 2024
@akien-mga akien-mga merged commit a30fbc5 into godotengine:master May 1, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@fkeyzuwu fkeyzuwu deleted the patch-1 branch May 1, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants