Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Fixes for warn/error colorization #91318

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Apr 29, 2024

Fixes a handful of regressions from #91220:

  • mingw no longer fails when trying to output in a non-verbose environment
  • compilation timer now uses explicit gray coloration (previously showed up as black on GitHub Actions)

@Calinou
Copy link
Member

Calinou commented Apr 29, 2024

  • compilation timer now uses explicit gray coloration (previously showed up as black on GitHub Actions)

I'm disappointed that GitHub Actions doesn't act like other terminal emulators here 🙁
"bright black" (\e[90m) shows up as gray in most terminals.

Using a 256-color gray works, but it also means that it may be harder to read on a light theme, since the user can't adjust its appearance anymore (not in most terminal emulators at least). When using 256 colors without a background color defined, make sure the text remains readable on both dark and light theme.

@Repiteo
Copy link
Contributor Author

Repiteo commented Apr 29, 2024

I went with the 50% gray for that reason; seems to show up fine on GitHub & is roughly as visible on VSCode as the old "black" text.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected (Linux).

@akien-mga akien-mga merged commit 506e2bc into godotengine:master Apr 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the scons/colorize-warn-error-pt2 branch May 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants