Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note for String::reverse to warn about its implementation #91321

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Apr 29, 2024

Just a note for String/StringName docs to warn user to not use emojis/compound symbols with that method. This is an addition for #78529 implementation.

@Chaosus Chaosus requested a review from a team as a code owner April 29, 2024 17:35
@Chaosus Chaosus added this to the 4.3 milestone Apr 29, 2024
@Chaosus Chaosus force-pushed the doc_string_reverse branch 2 times, most recently from 8785817 to 5911b13 Compare April 29, 2024 17:42
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 29, 2024
@Zireael07
Copy link
Contributor

Just FYI it seems to be an extremely common limitation of Strings in many programming languages - I'd even go as far as to say it's an Unicode limitation instead of a language's

@AThousandShips
Copy link
Member

I'd say there are ways to do it but it's not normally done for performance, it's not so much a limitation as an expensive operation, I'd expect there to be a unicode method for accomplishing this

@Calinou
Copy link
Member

Calinou commented Apr 29, 2024

I think libicu makes this possible, but it likely requires having ICU data available, which isn't shipped by default when exporting a project as it's several dozen megabytes.

doc/classes/String.xml Outdated Show resolved Hide resolved
@Chaosus Chaosus force-pushed the doc_string_reverse branch from 5911b13 to d0af890 Compare April 30, 2024 09:33
@akien-mga akien-mga merged commit 4455747 into godotengine:master Apr 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the doc_string_reverse branch April 30, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement topic:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants