C#: Ignore late bound methods in MustBeVariantAnalyzer #91368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this safe (and worth it) to cherry-pick for 4.2? |
paulloz
approved these changes
Apr 30, 2024
|
It's safe but will likely not cherry-pick cleanly because of surrounding changes. I don't think it's worth cherry-picking though since |
|
Maybe adding a test, to prevent future regressions 👀 |
If symbol is late bound (as is the case when using `dynamic`) we can't obtain the symbol to analyze the usage of `[MustBeVariant]`.
raulsntos
force-pushed
the
dotnet/must-be-variant-dynamic
branch
from
6f022dc
to
1510f88
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If symbol is late bound (as is the case when using
dynamic) we can't obtain the symbol to analyze the usage of[MustBeVariant].CSC : warning AD0001: Analyzer 'Godot.SourceGenerators.MustBeVariantAnalyzer'#91345.