Unhide carets in add selection for occurrence and fix error #91390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, worth adding a small unit test? |
kitbdev
force-pushed
the
add-selection-unhide-carets
branch
from
004445e to
8d8a7be
Compare
kitbdev
force-pushed
the
add-selection-unhide-carets
branch
from
8d8a7be to
948f096
Compare
|
Added test to make sure it unfolds. |
Paulb23
approved these changes
Jun 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctrl+dwith some multi line selections #71217Applies to both
add_selection_for_next_occurrence(ctrl+d) andskip_selection_for_next_occurrence(ctrl+alt+d).Uses the selection from line in the search, this way if multiple lines are selected nothing happens instead of printing an error.
Uses
_unhide_carets();from #86978 to make sure the carets are always visible.