GDScript: Fix access non-static members in static context #91412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dalexeev
commented
May 1, 2024
dalexeev
commented
- Fixes Non-static methods can't be referenced as Callables from static methods #91403.
dalexeev
force-pushed
the
gds-fix-non-static-access-in-static-context
branch
from
bd301e8
to
8122a27
Compare
dalexeev
commented
May 1, 2024
Comment on lines
-4049
to
+4065
| // If the identifier is a member variable (including the native class properties) or a signal, we consider the lambda to be using `self`, so we keep a reference to the current instance. | ||
| if (source_is_variable || source_is_signal) { | ||
| // If the identifier is a member variable (including the native class properties), member function, or a signal, | ||
| // we consider the lambda to be using `self`, so we keep a reference to the current instance. | ||
| if (source_is_instance_variable || source_is_instance_function || source_is_signal) { |
There was a problem hiding this comment.
This is an "unrelated" change, but I guess it makes sense? At least the tests did not detect regressions, but this is not always a reliable criterion.
Comment on lines
+74
to
+75
| test_static_var_lambda = null | ||
| test_non_static_var_lambda = null |
There was a problem hiding this comment.
This fixes memory leaks in CI. I'm not sure if this is a bug, but it's probably unrelated to the changes since I've noticed this problem before.
There was a problem hiding this comment.
It's a reference cycle. Lambda contains a reference to self which in turn contains a reference to the lambda. Not sure if there's a good way to solve it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.