Fix FileSystemDock thumbnails sometimes not displaying
#91471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were (at least) three cases where thumbnails would not display, if they were generated while the FileSystemDock was not visible: - current_path == "Favorites", due to p_path not starting with "Favorites" - current_path == "res://", due to current_path having last "/" trimmed for comparison - current_path pointing to a selected file instead of folder, since it no longer matches p_path's base directory This change removes the current_path and is_visible_in_tree checks when determining whether to update the file's icon. Fixes godotengine#90801 Fixes godotengine#91432
|
There's also the option of adding additional checks for each specific case. It seemed safer to just remove the checks, so we don't have to worry about missing cases, and the work of generating the preview texture has already completed anyway. If there's concerns about performance, I could change this to add checks for each of the listed cases. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were (at least) three cases where thumbnails would not display, if they were generated while the
FileSystemDockwas not visible:-
current_path== "Favorites", due top_pathnot starting with "Favorites"-
current_path== "res://", due tocurrent_pathhaving last "/" trimmed for comparison-
current_pathpointing to a selected file instead of folder, since it no longer matchesp_path's base directoryThis change removes the
current_pathandis_visible_in_treechecks when determining whether to update the file's icon.Fixes #90801
Fixes #91432