Apply WS_MINIMIZE style on window creation
#91487
Merged
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Tested locally (rebased on top of master 84dcdde), it works as expected on Windows 11 23H2. Window modes other than Minimized are unaffected by this PR (as expected).
This makes for a nice easy way to hide the boot splash (albeit with a taskbar entry still being visible during boot), since you can set the window mode to Minimized in the Project Settings and restore the window in an autoloaded script's _ready() method.
bruvzg
approved these changes
Oct 4, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Windows only
Current behavior
When the window mode is "Minimized", the main window is displayed for a moment and then minimized to the taskbar.
PR behavior
The main window is created with "WS_MINIMIZE" style, and won't show up until all initialization is complete.
It also needs #88289 to render correctly.