-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update area_create
description in PhysicsServer2D/3D
to clear up possible confusions
#91581
Update area_create
description in PhysicsServer2D/3D
to clear up possible confusions
#91581
Conversation
Looks good to me. Please copy the whole description to the method with the same name in If you have time, please add the same information to |
PhysicsServer2D/3D
to clear up possible confusions
Updated description for Since body doesn't have monitoring/monitorable properties I mentioned the default BodyMode there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Please squash your commits into one, see here |
Please clean up the commit message so it's just the necessary information, like the PR title, excluding all the "Update X" messages |
I think I managed to do it, should I create a separate PR for body_create changes? |
PhysicsServer2D/3D
to clear up possible confusionsarea_create
description in PhysicsServer2D/3D
to clear up possible confusions
Thanks! And congrats for your first merged Godot contribution 🎉 |
I'm a newbie who never worked with game engine before so apologies in advance if this is incorrect.
I spent way too long trying to figure out why collisions with areas created from Area2D nodes were working but not between areas created using PhysicsServer2D.area_create().
From my testing it looks like by default the
monitorable
property is set to false, which can be confusing since there is no easy way to check it (noarea_get_monitorable()
method for example). Especially since areas created with Area2D nodes have this enabled by default.To reduce chances other people will be confused like me I updated the description of the method to explicitly state that.
I didn't mention
monitoring
property since areas are always monitoring, and disabling it in Area2D node just means setting empty callback. If you think there may be value in adding this as well, feel free to suggest changes.