Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextEdit minimap tab drawing and click check #91720

Merged
merged 1 commit into from
May 17, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented May 8, 2024

Fixes color leak from last color used in minimap to the lookup_symbol_word underline (hold control and hover).

Rewrites the character drawing logic to use a for loop instead of continues, so it can check the next character without needing to go back. This simplifies the logic and was needed to calculate the tab alignment since it can't be reversed.

Also clarified in the docs that the minimap text is fixed-width, since if the font used is not monospaced then it won't match.

Example text:

image

Before:

image

After:

image

@kitbdev kitbdev requested review from a team as code owners May 8, 2024 16:13
@YeldhamDev YeldhamDev added this to the 4.3 milestone May 8, 2024
@akien-mga akien-mga merged commit 6235374 into godotengine:master May 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants