Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thorvg: Update to 0.13.3, add webp loader #91788

Merged
merged 1 commit into from
May 11, 2024

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented May 10, 2024

Remove embedded png loader, we use the external (libpng) one.
@akien-mga akien-mga added this to the 4.3 milestone May 10, 2024
@akien-mga akien-mga requested review from a team as code owners May 10, 2024 07:31
@akien-mga
Copy link
Member Author

CC @capnm @MewPurPur

@Maran23
Copy link
Contributor

Maran23 commented May 10, 2024

Also worth checking if this fixes/has something to do with: #88165

@akien-mga
Copy link
Member Author

Also worth checking if this fixes/has something to do with: #88165

I tried, doesn't seem to impact this.

@akien-mga akien-mga added the bug label May 10, 2024
@Maran23
Copy link
Contributor

Maran23 commented May 10, 2024

I tried, doesn't seem to impact this.

Thanks for checking! I will do a bisect to check where this regression came from.

@fire fire self-requested a review May 10, 2024 16:45
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imported the test case from #90371 and it did not crash.

This is a basic test and does not go into depth with technical review of thorvg.

editor_screenshot_2024-05-10T094842

@akien-mga akien-mga merged commit 1cf283d into godotengine:master May 11, 2024
16 checks passed
@akien-mga akien-mga deleted the thorvg-0.13.3 branch May 11, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heap buffer overflow when loading some SVG image
3 participants