Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Tighter light culling - fix directional lights colinear case #91789

Merged
merged 1 commit into from
May 10, 2024
Merged

[3.x] Tighter light culling - fix directional lights colinear case #91789

merged 1 commit into from
May 10, 2024

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented May 10, 2024 •
edited
Loading

Exactly the same fix as done already for non-directional lights.

Fixes #89560 for 3.x

Notes

@lawnjelly
Tighter light culling - fix directional lights colinear case
b09bc22 
Exactly the same fix as done already for non-directional lights.
@lawnjelly lawnjelly added this to the 3.6 milestone May 10, 2024
@lawnjelly lawnjelly requested a review from a team as a code owner May 10, 2024 08:09
@lawnjelly lawnjelly changed the title Tighter light culling - fix directional lights colinear case [3.x] Tighter light culling - fix directional lights colinear case May 10, 2024
@lawnjelly lawnjelly merged commit 30b025d into godotengine:3.x May 10, 2024
14 checks passed
@lawnjelly
Copy link
Member Author

Thanks!

@lawnjelly lawnjelly deleted the fix_tight_light_cull_directional_colinear branch May 12, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@lawnjelly @akien-mga