[Web] Fix debug symbols in web builds #91800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
May 25, 2024
This was referenced Jul 8, 2024
|
The findings in #94088 confirm that passing those to the linker is needed for Emscripten. I don't think it's harmful for other toolchains. |
I see, I've updated this PR with my latest finding, i.e. that emscripten requires I think this is ready for review 👀 |
akien-mga
approved these changes
Jul 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seem to have regressed at some point, not sure if it regressed in emcc or the godot build system yet.
In general,
-goptions are also link flags emcc.Draft as this needs some more investigation.