Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert start offset on AnimationNode custom timeline #91822

Merged
merged 1 commit into from
May 11, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented May 11, 2024

Custom timelines were added in #87171. Its purpose was to set the period of a loop animation, moving the timeline by the number of offsets.

This functionality could be reused to specify section, but in its current behavior, it would set the negative value there generally. Then, it is not consistent with AudioTrack's offset behavior and violates affordance, so the sign must be inverted.

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to review this deeply with the test cases, but it is an important fix.

@fire fire requested a review from a team May 11, 2024 14:09
@akien-mga akien-mga merged commit 10471a4 into godotengine:master May 11, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the inv-offset branch June 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants