Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiMesh buffer cache in transforms-only case #91846

Merged
merged 1 commit into from
May 14, 2024

Conversation

rburing
Copy link
Member

@rburing rburing commented May 11, 2024

Just updates the cache.

The issue was found while implementing

The fix was found with the help of @clayjohn on RocketChat #rendering.

@rburing rburing added this to the 4.3 milestone May 11, 2024
@rburing rburing marked this pull request as ready for review May 11, 2024 18:57
@rburing rburing requested a review from a team as a code owner May 11, 2024 18:57
@rburing rburing force-pushed the multimesh_cache_me_if_you_can branch from ed2a2d4 to a24cb7b Compare May 11, 2024 19:10
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@clayjohn clayjohn added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label May 14, 2024
@akien-mga akien-mga merged commit d532bc5 into godotengine:master May 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the multimesh_cache_me_if_you_can branch May 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants