Allow specifying a key when loading resource packs #91884
+50
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basicer
changed the title
basicer
force-pushed
the
load_resource_pack_encrypted
branch
from
cccc959 to
b9a23e4
Compare
basicer
force-pushed
the
load_resource_pack_encrypted
branch
from
b9a23e4 to
edd73a4
Compare
basicer
force-pushed
the
load_resource_pack_encrypted
branch
2 times, most recently
from
3bd82c1 to
b8c0aaf
Compare
basicer
force-pushed
the
load_resource_pack_encrypted
branch
from
b8c0aaf to
d547adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends ProjectSettings with
load_resource_pack_encrypted, allowing a custom decryption key to be specified.The code could be refactored a bit more nicely, but I wanted to avoid passing around the embedded secret key as much as possible.
See godotengine/godot-proposals#9726 for rationale.