Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Remove useless isFirstEntry and useless source.Append("else ") #91924

Merged
merged 1 commit into from
May 14, 2024
Merged

[C#] Remove useless isFirstEntry and useless source.Append("else ") #91924

merged 1 commit into from
May 14, 2024

Conversation

ZerxZ
Copy link
Contributor

@ZerxZ ZerxZ commented May 13, 2024 •
edited
Loading

PR #90687 (comment)

Even removing the else keyword does not affect program execution.

@ZerxZ ZerxZ changed the title Remove useless isFirstEntry and useless source.Append("else ") [C#]Remove useless isFirstEntry and useless source.Append("else ") May 13, 2024
@ZerxZ ZerxZ force-pushed the dotnet/useless-is-first-entry branch from 2d81a99 to e49c254 Compare May 13, 2024 23:10
@ZerxZ ZerxZ marked this pull request as ready for review May 13, 2024 23:11
@ZerxZ ZerxZ requested a review from a team as a code owner May 13, 2024 23:11
@ZerxZ ZerxZ changed the title [C#]Remove useless isFirstEntry and useless source.Append("else ") [C#]Remove useless isFirstEntry and useless source.Append("else ") May 13, 2024
@ZerxZ ZerxZ force-pushed the dotnet/useless-is-first-entry branch from e49c254 to a17e2c5 Compare May 13, 2024 23:23
@timothyqiu timothyqiu added this to the 4.3 milestone May 14, 2024
raulsntos
raulsntos reviewed May 14, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good cleanup. Make sure to also remove the remaining excessive whitespace.

modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ScriptPropertiesGenerator.cs Outdated Show resolved Hide resolved
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ScriptPropertiesGenerator.cs Outdated Show resolved Hide resolved
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ScriptPropertiesGenerator.cs Outdated Show resolved Hide resolved
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ScriptSignalsGenerator.cs Outdated Show resolved Hide resolved
@ZerxZ
Copy link
Contributor Author

ZerxZ commented May 14, 2024

Thanks, this is a good cleanup. Make sure to also remove the remaining excessive whitespace.

Thank! I'll fix it right away.

@ZerxZ ZerxZ force-pushed the dotnet/useless-is-first-entry branch from a17e2c5 to e327011 Compare May 14, 2024 05:46
raulsntos
raulsntos approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akien-mga akien-mga changed the title [C#]Remove useless isFirstEntry and useless source.Append("else ") [C#] Remove useless isFirstEntry and useless source.Append("else ") May 14, 2024
@ZerxZ
Copy link
Contributor Author

ZerxZ commented May 14, 2024

LGTM. Thanks!

Thanks!

@akien-mga akien-mga merged commit 882449f into godotengine:master May 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@ZerxZ
Copy link
Contributor Author

ZerxZ commented May 14, 2024

Thanks!

Thanks!

@ZerxZ ZerxZ deleted the dotnet/useless-is-first-entry branch May 15, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:dotnet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ZerxZ @akien-mga @raulsntos @timothyqiu