Cleanup unused/underused singleton StringNames #91948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 14, 2024
KoBeWi
force-pushed
the
brutal_string_culling
branch
from
453d23c
to
1a4bc76
Compare
akien-mga
approved these changes
May 14, 2024
AThousandShips
approved these changes
May 14, 2024
|
Needs rebase. |
KoBeWi
force-pushed
the
brutal_string_culling
branch
2 times, most recently
from
2335e69
to
b934ffd
Compare
KoBeWi
force-pushed
the
brutal_string_culling
branch
from
b934ffd
to
59f05ed
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #91909 (likely final one)
Removes many unused names from core/scene string names. If a name was used exactly once, it's replaced with SNAME (for single use they are pretty much equivalent).
Most of the removed names are few-year-old leftovers obsoleted after GDVIRTUAL was added.
EDIT:
I forgot to mention, but this does not handle 1-2 character-long names, because they are difficult to track.