Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use COM smart pointers in WASAPI driver #91975

Merged
merged 1 commit into from
May 17, 2024
Merged

Use COM smart pointers in WASAPI driver #91975

merged 1 commit into from
May 17, 2024

Conversation

lalitshankarchowdhury
Copy link
Contributor

Use COM smart pointer (ComPtr) to simplify memory management in WASAPI driver.

This reduces chances of calling Release() when a COM object has not been allocated.

@lalitshankarchowdhury lalitshankarchowdhury requested a review from a team as a code owner May 15, 2024 10:15
@akien-mga
Copy link
Member

Thanks for the contribution!

Could you rebase your branch on latest upstream master to remove the merge commit? See https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase

@akien-mga akien-mga added this to the 4.x milestone May 15, 2024
@akien-mga akien-mga requested a review from a team May 15, 2024 10:33
@lalitshankarchowdhury
Copy link
Contributor Author

Thanks for the contribution!

Could you rebase your branch on latest upstream master to remove the merge commit? See https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase

Done.

bruvzg
bruvzg approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits, see pull request workflow.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 16, 2024
@lalitshankarchowdhury
Use COM smart pointers to handle COM objects safely
8b8c497 
Use ComPtr to handle COM objects safely

Use COM smart pointers in WASAPI driver

Fix ComPtr handling

Fix crash due to IAudioClient3 type conversion
@lalitshankarchowdhury
Copy link
Contributor Author

Fixed crash on Windows when IAudioClient3 was being initialized.

@akien-mga akien-mga merged commit 04a8cfb into godotengine:master May 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@matheusmdx matheusmdx mentioned this pull request Sep 14, 2024
Closed
@akien-mga akien-mga mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg Awaiting requested review from bruvzg

Assignees
No one assigned
Labels
enhancement platform:windows topic:audio
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lalitshankarchowdhury @akien-mga @bruvzg