[CI] Fix for jsdoc hook in pre-commit #92013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
This is a fix for
jsdoc
hook from #91597Currently, the hooks in the pre-commit are only triggered if the specified files have been modified. In the case of the jsdoc hook, engine.js, config.js and features.js from the
platform/web/js/engine
directory are checked.The problem is that jsdoc requires all these 3 files in the parameter line and not, as pre-commit does, only those that were modified in the commit.
When, for example, only
feature.js
is changed in a commit, an error will appear:The solution is to permanently add the names of all 3 files to the argument line and disable the automatic addition of modified file names by pre-commit (
pass_filenames: false
).