-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stereo rendering: Fix omni lights #92186
Stereo rendering: Fix omni lights #92186
Conversation
@clayjohn I think this could use a rework at some point so that we rebind the correct uniform buffers after we perform the sky process, but for now I've solved it the same way this was already solved for the conflict with |
#82278 might be the same issue, does this fix it too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this has gotten quite ugly. We should probably reorganize at some point, but this change is fine for now
Awesome debugging, been troubled by this as well. |
10d389d
to
db32707
Compare
Thanks! @BastiaanOlij I see you flagged this for a 4.2 cherrypick, which makes sense. Do you think it would also cherry-pick and work properly for 4.1? |
@akien-mga I think this has been in there for a long time so probably yes, but I think someone might want to test that hypothesis. |
This one was super dumb.
Turns out setting stereo rendering for sky set uniform location 5 to the uniform buffer containing Multiview data for the sky.
Geometry rendering however uses this to access the omni light buffer.
The result is that the rendering was accessing the incorrect data.