Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OpenXRCompositionLayer property layer_viewport to always be assigned nullptr #92200

Merged

Conversation

devloglogan
Copy link
Contributor

If you have multiple OpenXRCompositionLayer nodes and at least one of them does not have a viewport assigned, users are not able to return an assigned layer_viewport property to its default value (nullptr). This fixes that.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm able to reproduce the issue, and this PR fixes it. The code looks good to me.

Hopefully, this is the last bug we have to fix in this logic! :-)

@akien-mga akien-mga merged commit 4c0d5e5 into godotengine:master May 21, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants