Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Input::frame_parsed_events before de-initialising scripting languages to ensure no script created events exist at the exit. #92201

Merged
merged 1 commit into from
May 30, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented May 21, 2024

A quick fix for #83973, should address the crash reason, but C# object cleanup probably should be investigated further to avoid similar issues.

Fixes #83973, and probably fixes #89188 (at least MRP in the first comment).

@bruvzg bruvzg added this to the 4.3 milestone May 21, 2024
@bruvzg bruvzg requested review from a team as code owners May 21, 2024 13:00
@akien-mga akien-mga added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels May 21, 2024
core/input/input.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga changed the title Clean Input::frame_parsed_events before de-initialising scripting languages to ensure no script created events exist at the exit. Clean Input::frame_parsed_events before de-initialising scripting languages to ensure no script created events exist at the exit. May 30, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, pending minor change suggested by Pedro.

…guages to ensure no script created events exist at the exit.
@akien-mga akien-mga merged commit be2c5e6 into godotengine:master May 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release crash topic:input
Projects
None yet
3 participants