Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unchecking theme overrides not creating an undo action #92207

Merged
merged 1 commit into from
May 23, 2024

Conversation

YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented May 21, 2024

Before, unchecking a theme override in the inspector didn't create an undo action, which meant the possibility of losing it if you're not careful.

Fixes #55455.

@YeldhamDev YeldhamDev added this to the 4.3 milestone May 21, 2024
@YeldhamDev YeldhamDev requested a review from a team May 21, 2024 15:38
@KoBeWi
Copy link
Member

KoBeWi commented May 21, 2024

Does it fix #55455?

@YeldhamDev
Copy link
Member Author

It does. Didn't the see the report, issue linked.

@KoBeWi
Copy link
Member

KoBeWi commented May 22, 2024

Tested and it doesn't. It only handles the case where the checkbox is disabled, not enabled.

@YeldhamDev
Copy link
Member Author

Alright, try again.

@KoBeWi
Copy link
Member

KoBeWi commented May 23, 2024

Now there is undoredo for both, but after you undo, the action might not register.

godot.windows.editor.dev.x86_64_EXX87bq7XM.mp4

Also, sometimes the checkbox can't be clicked (it has no effect). Might be related to the above.

@YeldhamDev
Copy link
Member Author

Can you tell me the order of events step-by-step? I'm unable to reproduce your issues.

@KoBeWi
Copy link
Member

KoBeWi commented May 23, 2024

Ok this is caused by operation merging. If you toggle multiple times too fast, some toggles will be skipped from undo. This is not something that would normally happen, so it's probably fine.

The unclickable checkbox might be caused by tooltips, so also unrelated.

@YeldhamDev
Copy link
Member Author

Ok this is caused by operation merging. If you toggle multiple times too fast, some toggles will be skipped from undo. This is not something that would normally happen, so it's probably fine.

This seems to happen to all toggleable properties, so not related to my PR.

The unclickable checkbox might be caused by tooltips, so also unrelated.

Suspected as much, but just wanted to be sure.

@akien-mga akien-mga merged commit dab6e15 into godotengine:master May 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the undo_theme_fix branch May 23, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme override checkbox is oblivious to undo
3 participants