-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unchecking theme overrides not creating an undo action #92207
Conversation
Does it fix #55455? |
It does. Didn't the see the report, issue linked. |
Tested and it doesn't. It only handles the case where the checkbox is disabled, not enabled. |
15c84f2
to
e1798f4
Compare
Alright, try again. |
Now there is undoredo for both, but after you undo, the action might not register. godot.windows.editor.dev.x86_64_EXX87bq7XM.mp4Also, sometimes the checkbox can't be clicked (it has no effect). Might be related to the above. |
Can you tell me the order of events step-by-step? I'm unable to reproduce your issues. |
Ok this is caused by operation merging. If you toggle multiple times too fast, some toggles will be skipped from undo. This is not something that would normally happen, so it's probably fine. The unclickable checkbox might be caused by tooltips, so also unrelated. |
This seems to happen to all toggleable properties, so not related to my PR.
Suspected as much, but just wanted to be sure. |
Thanks! |
Before, unchecking a theme override in the inspector didn't create an undo action, which meant the possibility of losing it if you're not careful.
Fixes #55455.