Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bounding box glitch #92275

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix bounding box glitch #92275

merged 1 commit into from
May 23, 2024

Conversation

ajreckof
Copy link
Member

Fixes #91860

@ajreckof ajreckof requested a review from a team as a code owner May 23, 2024 09:09
@AThousandShips
Copy link
Member

Assuming this is meant to be a draft? Otherwise you'll want to remove your debug prints

@AThousandShips AThousandShips added this to the 4.3 milestone May 23, 2024
@ajreckof ajreckof force-pushed the fix-bounding-box-glitch- branch from 01dbdcb to 35c67d1 Compare May 23, 2024 09:12
@ajreckof
Copy link
Member Author

Thanks forgot to remove them before commiting

AThousandShips
AThousandShips reviewed May 23, 2024
View reviewed changes
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
@ajreckof ajreckof force-pushed the fix-bounding-box-glitch- branch from 35c67d1 to 32e29cc Compare May 23, 2024 09:19
KoBeWi
KoBeWi approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue suggests that 3D editor is doing something wrong with the selection.
This fix is safe though, so the cause can be investigated later.

@ajreckof
Copy link
Member Author

This might also be a case that should never happen as I was in this case replacing a selection by the same selection. This is most likely something that does not happen often and might even be something that shouldn't happen at all.

@akien-mga akien-mga merged commit bceebdf into godotengine:master May 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Bounding box glitch after selecting different nodes
4 participants
@ajreckof @AThousandShips @akien-mga @KoBeWi